Usability improvements for custom keyboard controls #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
zachallaun
force-pushed
the
keyboard-control-2
branch
from
de6feaa
to
7573b91
Compare
|
Link to open playground notebook in PR environment: link |
zachallaun
commented
Aug 7, 2023
josevalim
reviewed
Aug 7, 2023
* Add `:default_handlers` option to control whether the default Livebook shortcuts are enabled/disabled when the keyboard control is active. * Add `ctrl/cmd + k` session shortcut to toggle keyboard controls.
Co-authored-by: José Valim <jose.valim@gmail.com>
zachallaun
force-pushed
the
keyboard-control-2
branch
from
10b2cfb
to
cfa7c9c
Compare
|
Thanks for the review @jonatanklosko! I'll have this (and the Kino PR) updated after I drop the kiddo off at school this morning. |
|
@jonatanklosko done! |
zachallaun
force-pushed
the
keyboard-control-2
branch
from
dd6fc17
to
db9a447
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion for context.
:default_handlersoption to control whether the default Livebook shortcuts are enabled/disabled when the keyboard control is active.ctrl/cmd + ksession shortcut to toggle keyboard controls.Basic notebook for testing: gist
Corresponding PR in Kino: livebook-dev/kino#312