Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote cell definition #2197

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Remote cell definition #2197

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
836ebbc
Remote cell definition
cristineguadelupe Sep 4, 2023
9c441d1
Applying suggestions
cristineguadelupe Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/livebook/runtime/definitions.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,21 @@ defmodule Livebook.Runtime.Definitions do
packages: [kino_explorer]
}
]
},
%{
kind: "Elixir.Kino.RemoteCell",
name: "Remote cell",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other options: "Remote node", "Remote execution", "Remote procedure call", "Distributed Elixir".

The last one may be the most clear one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like "Remote execution".

Whatever we pick, we should mirror the name in kino :)

requirement_presets: [
%{
name: "Default",
packages: [
%{
name: "kino",
dependency: %{dep: {:kino, github: "livebook-dev/kino", branch: "main"}, config: []}
}
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
packages: [
%{
name: "kino",
dependency: %{dep: {:kino, github: "livebook-dev/kino", branch: "main"}, config: []}
}
]
packages: [kino]

You can change

livebook/lib/livebook/runtime/definitions.ex

Line 6 in 836ebbc

dependency: %{dep: {:kino, "~> 0.10.0"}, config: []}
to {:kino, github: "livebook-dev/kino", override: true}

}
]
}
]

Expand Down
Loading