-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktop: Add "Open .livebookdesktop.sh|bat" menu item #2225
Conversation
cc @mat-hek |
Uffizzi Preview |
I just realised we might be able to have a System.put_env("LIVEBOOK_PORT", "9999") whereas users might have expected a more Elixir-centric API, e.g.: All this being said perhaps it is not easy or impossible to make it work, e.g. the file would have been evaluated too late. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I have added some suggestions to the generated files. :)
Co-authored-by: José Valim <jose.valim@dashbit.co>
This is especially useful for the ZTA feature because we need to set
LIVEBOOK_IDENTITY_PROVIDER
somewhere.I've updated nightlies with this branch:
Demo on macOS:
Demo on Windows: