Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: Add "Open .livebookdesktop.sh|bat" menu item #2225

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

wojtekmach
Copy link
Contributor

@wojtekmach wojtekmach commented Sep 23, 2023

This is especially useful for the ZTA feature because we need to set LIVEBOOK_IDENTITY_PROVIDER somewhere.

I've updated nightlies with this branch:

Demo on macOS:

Untitled-5

Demo on Windows:

Untitled-4

@wojtekmach
Copy link
Contributor Author

cc @mat-hek

@github-actions
Copy link

github-actions bot commented Sep 23, 2023

Uffizzi Preview deployment-36680 was deleted.

@wojtekmach
Copy link
Contributor Author

I just realised we might be able to have a ~/.livebookdesktop.exs instead. It would work like a config/runtime.exs. I think the benefit would be we'd have same syntax for all platforms. On the flip side maybe it would be awkward to write there:

System.put_env("LIVEBOOK_PORT", "9999")

whereas users might have expected a more Elixir-centric API, e.g.: config :livebook, ....

All this being said perhaps it is not easy or impossible to make it work, e.g. the file would have been evaluated too late.

Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I have added some suggestions to the generated files. :)

Co-authored-by: José Valim <jose.valim@dashbit.co>
@wojtekmach wojtekmach merged commit a82345d into main Sep 23, 2023
6 checks passed
@wojtekmach wojtekmach deleted the wm-open-boot-menu branch September 23, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants