Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Teleport ZTA method #2296

Merged
merged 3 commits into from
Oct 25, 2023
Merged

add Teleport ZTA method #2296

merged 3 commits into from
Oct 25, 2023

Conversation

slashmili
Copy link
Contributor

In this PR I'm adding Teleport authentication support.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

josevalim
josevalim reviewed Oct 24, 2023
View reviewed changes
lib/livebook/config.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Oct 24, 2023
View reviewed changes
lib/livebook/config.ex Outdated Show resolved Hide resolved
@josevalim
Copy link
Contributor

Note to self: rename opts[:identity][:key] to opts[:identity_key] and add entry to the README.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Uffizzi Preview deployment-39369 was deleted.

@josevalim
Copy link
Contributor

@hugobarauna we should add teleport to the integrations page. :)

@josevalim josevalim merged commit 586788c into livebook-dev:main Oct 25, 2023
7 checks passed
@slashmili slashmili deleted the zta-teleport branch October 25, 2023 09:12
@slashmili
Copy link
Contributor Author

Based on #2581 discussion it's not possible to put Livebook behind Teleport. This PR needs to be reverted but for some reason I can't do it via GitHub's UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

@jonatanklosko jonatanklosko jonatanklosko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slashmili @CLAassistant @josevalim @jonatanklosko