-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom identity providers #2301
Conversation
Uffizzi Preview |
Perhaps we should have |
|
||
@spec authenticate(GenServer.server(), Plug.Conn.t(), keyword()) :: | ||
{Plug.Conn.t(), map() | nil} | ||
def authenticate(server, conn, opts \\ []) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks good, the only issue I see is dependencies. Someone may use Req
(the most likely), then if we bump it in Livebook it's can break their code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add a note about this. Once we extract ZTA, we can say they can use both req and jose packages according to the nimble_zta package but for now I will explicitly list them.
@jonatanklosko should we move env.sh to extensions/env.sh?