Custom identity providers #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
Perhaps we should have |
|
|
||
| @spec authenticate(GenServer.server(), Plug.Conn.t(), keyword()) :: | ||
| {Plug.Conn.t(), map() | nil} | ||
| def authenticate(server, conn, opts \\ []) do |
There was a problem hiding this comment.
The approach looks good, the only issue I see is dependencies. Someone may use Req (the most likely), then if we bump it in Livebook it's can break their code.
There was a problem hiding this comment.
I will add a note about this. Once we extract ZTA, we can say they can use both req and jose packages according to the nimble_zta package but for now I will explicitly list them.
josevalim
commented
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonatanklosko should we move env.sh to extensions/env.sh?