-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a connection error for offline hubs #2326
Conversation
Uffizzi Preview |
@@ -38,7 +38,7 @@ defmodule Livebook.Hubs.Team do | |||
field :org_key_id, :integer | |||
field :teams_key, :string | |||
field :org_public_key, :string | |||
field :session_token, :string | |||
field :session_token, :string, redact: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do that for the teams key too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The teams key is not strictly necessary and I thought having it in logs may help if someone loses it :P
@@ -312,7 +312,7 @@ defmodule Livebook.Application do | |||
Livebook.Hubs.save_hub(%Livebook.Hubs.Team{ | |||
id: "team-#{name}", | |||
hub_name: name, | |||
hub_emoji: "💡", | |||
hub_emoji: "⭐️", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want something more indicative, perhaps 🔓 or 📦, but it's whatever :D
💚 💙 💜 💛 ❤️ |
No description provided.