Ignore channel events for unknown JS Views #2363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2362.
We are multiplexing JSView events through a single channel, so each JSView needs to send "connect" event to register. When the connection is lost the JSView information is discarded and it needs to register again, by remounting the client-side hook (when the LV channel is reconnected):
livebook/assets/js/hooks/js_view.js
Lines 165 to 168 in d345c9e
However, it is possible that when both channels reconnect we push (or flush accumulated) events, before the hook is destroyed and mounted again.
I was considering solving this on the client, but in this case I think it's actually simpler and more reliable to do it on the server.