Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unambiguous mapping between erlang and elixir variable names #2556

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Use unambiguous mapping between erlang and elixir variable names #2556

merged 2 commits into from
Apr 9, 2024

Conversation

jonatanklosko
Copy link
Member

Closes #2551.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

Uffizzi Preview deployment-49800 was deleted.

@jonatanklosko jonatanklosko changed the title Use ambiguous mapping between erlang and elixir variable names Use unambiguous mapping between erlang and elixir variable names Apr 9, 2024
@jonatanklosko jonatanklosko merged commit 6d994a5 into main Apr 9, 2024
7 checks passed
@jonatanklosko jonatanklosko deleted the jk-erlang-elixir-binding branch April 9, 2024 10:35
josevalim
josevalim reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, using ranges may be clearer, h in ?a..?z. Your call.

@jonatanklosko
Copy link
Member Author

Ah good call, updated on main!

spunkedy pushed a commit to spunkedy/livebook that referenced this pull request Apr 22, 2024
@jonatanklosko @spunkedy
Use unambiguous mapping between erlang and elixir variable names (liv…
1d144ae 
…ebook-dev#2556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Information loss with current variable name binding model (JSON -> Json)
2 participants
@jonatanklosko @josevalim