Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove teleport, as it does not support smart cells #2589

Merged
merged 1 commit into from
May 6, 2024

Conversation

josevalim
Copy link
Contributor

Closes #2584.

Copy link

github-actions bot commented May 1, 2024

Uffizzi Preview deployment-51101 was deleted.

@dkarter
Copy link

dkarter commented May 1, 2024

Hey @josevalim we are trying to implement livebook in our cluster which uses teleport. We did encounter some issues with the iframe and port forwarding with Teleport which caused some issues with the smart cells and Kino.

Does this PR mean that LiveBook cannot work with Teleport at all?

@josevalim
Copy link
Contributor Author

Please see #2581

Teleport needs to add an API to allow certain paths without authentication.

@dkarter
Copy link

dkarter commented May 1, 2024

That’s helpful, thank you! 💜

@josevalim josevalim merged commit eb48876 into main May 6, 2024
6 of 7 checks passed
@josevalim josevalim deleted the jv-remove-teleport branch May 6, 2024 21:58
@josevalim
Copy link
Contributor Author

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit teleport integration
3 participants