-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to enable font ligatures in the code editor #2609
Conversation
assets/js/lib/settings.js
Outdated
const DEFAULTSETTINGS = { | ||
editor_auto_completion: true, | ||
editor_auto_signature: true, | ||
editor_font_size: EDITOR_FONT_SIZE.normal, | ||
editor_theme: EDITOR_THEME.default, | ||
editor_ligatures: EDITOR_LIGATURES.off, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just make it a boolean, like editor_auto_completion
:)
@JBraungardt sounds good, just one comment and we can ship it! FTR we intentionally disable it by default, so that people new to Elixir are not confused with |
Uffizzi Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JBraungardt perfect!
Looks like you need to sign CLA with the other account that you pushed. Or perhaps you can squash and force push with the first one :)
Done |
As jetbrains-mono is used as the default font in the codemirror editor and this font has support for ligatures a new setting is added to enable rendering with ligatjures.
The default for this setting is off so that the current behavior is maintained.