Always run distribution in long names mode #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
josevalim
reviewed
Jun 12, 2024
josevalim
reviewed
Jun 12, 2024
josevalim
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been defaulting to short names distribution, but there is actually no good reason for that. See elixir-lang/elixir#13658.
Short names are more prone to OS misconfiguration, because connecting nodes involves resolving the hostname (and hostname defaults to the machine name). Almost the entirety of our installation FAQ is related to that, and it even suggests longnames as a solution.
Given this new default, I don't think there's any reason to support short names anymore. We are planning more features that involve distribution and supporting both modes would only add unnecessary complexity. The only thing we lose is the ability to connect to short name nodes, but those are basically always local nodes started by the user, in which case they may as well start them as long name nodes.