Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create duplicate log lines on Windows #2668

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Don't create duplicate log lines on Windows #2668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

* File download in the .exs notebook export
* (Desktop) `~/.livebookdesktop.sh` to allow setting `LIVEBOOK_NODE` and `LIVEBOOK_SHUTDOWN_ENABLED` ([#2464](https://github.com/livebook-dev/livebook/pull/2464))
* (Desktop) Don't create duplicate log lines on Windows ([#2668](https://github.com/livebook-dev/livebook/pull/2668))
* Using environment variables for S3 file system credentials ([#2472](https://github.com/livebook-dev/livebook/pull/2472))
* Redesigned flash messages to allow copying the message without closing it ([#2484](https://github.com/livebook-dev/livebook/pull/2484))
* Completion relevance within multiline maps and bitstrings ([#2488](https://github.com/livebook-dev/livebook/pull/2488))
Expand Down
6 changes: 0 additions & 6 deletions elixirkit/elixirkit_dotnet/ElixirKit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,6 @@ public Release(string name, ReadyHandler ready, ExitHandler? exited = null, stri
}
};

if (logPath != null)
{
logger.Capture(process);
}

process.StartInfo.Arguments = "start";
process.StartInfo.EnvironmentVariables.Add("ELIXIRKIT_PORT", $"{listener.Port}");

Expand All @@ -184,7 +179,6 @@ public Release(string name, ReadyHandler ready, ExitHandler? exited = null, stri
};

logger.Capture(process);

process.Start();
process.BeginOutputReadLine();
process.BeginErrorReadLine();
Expand Down
Loading