Change the scroll behavior when clicking notebook sections #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
josevalim
approved these changes
Jul 11, 2024
jonatanklosko
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the UI scrolling behavior when clicking a section in the section's sidebar.
This idea came up when I was watching a talk from Bruce Tate at an event. His whole talk was live coding using Livebook. After clicking the section items in the sidebar a few times, he said to the audience, "Are you feeling dizzy? I know I am."
While working on Livebook apps, I use the section navigation to help me navigate the codebase. I also noticed that the repeating smooth scrolling effect makes me feel a little bit dizzy.
This PR changes the scroll behavior from "smooth" to "instant."
Before
Link to video: https://share.cleanshot.com/jFB0bqWr
After
Link to video: https://share.cleanshot.com/gpFYvtdp