Respect default elements outline on tab-navigation #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
josevalim
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we disable focus outline on all elements, but this makes tab navigation hard, because in most many cases there is no indication of focus.
For certain elements we want to customize the tab-focused style, but using the
:focuspseudo-class is not ideal in many cases, because the element keeps the style when clicked, which in many cases is not desired. However, there is a relatively recent:focus-visibleCSS pseudo-class, which is already established enough to rely on.I iterated over the main views, notebook and form elements. We can do more adjustments as we go, but most changes are specific to tab-navigation, so the visual impact is minimal.