Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW-2825: Angular services tests #15

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Conversation

walaszczykm
Copy link
Collaborator

Type of change

  • Docs
  • Bug fix
  • Feature

Packages

  • @livechat/widget-core
  • @livechat/widget-react
  • @livechat/widget-vue
  • @livechat/widget-angular

Issue

https://livechatinc.atlassian.net/browse/CW-2825

Description

  • Move all *.service.ts files into the dedicated services directory.
  • Setup jest for @livechat/widget-angular package
  • Configure jest with jest-preset-angular in order to run Angular specific code in tests
  • Add tests for the services module

Full test coverage on Angular services exported from the @livechat/widget-angular package 🥳

@walaszczykm walaszczykm added the enhancement New feature or request label Jan 12, 2022
@walaszczykm walaszczykm requested review from klarzynskik and a team January 12, 2022 10:37
Base automatically changed from feature/vue-composition-tests to master January 12, 2022 13:11
Copy link
Member

@klarzynskik klarzynskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grande fenomeno! 🇮🇹

@walaszczykm walaszczykm merged commit 7aa438a into master Jan 12, 2022
@walaszczykm walaszczykm deleted the feature/angular-services-tests branch January 12, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants