Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW-2817: E2E tests #21

Merged
merged 3 commits into from
Jan 18, 2022
Merged

CW-2817: E2E tests #21

merged 3 commits into from
Jan 18, 2022

Conversation

klarzynskik
Copy link
Member

@klarzynskik klarzynskik commented Jan 17, 2022

Type of change

  • Docs
  • Bug fix
  • Feature

Packages

  • @livechat/widget-core
  • @livechat/widget-react
  • @livechat/widget-vue
  • @livechat/widget-angular

Issue

https://livechatinc.atlassian.net/browse/CW-2817

Description

This PR introduces a basic end-to-end test setup for the project. It runs using playwright and validates that all packages work as expected using the examples created with them.

Additionally, the small fix for the hardcoded sessionVariables values in the @livechat/widget-angular was introduced.

@klarzynskik klarzynskik force-pushed the feature/e2e-tests branch 13 times, most recently from 6b7ffa1 to 2e30d0e Compare January 18, 2022 12:07
@klarzynskik klarzynskik marked this pull request as ready for review January 18, 2022 12:19
@walaszczykm walaszczykm changed the title Basic setup for chat-widget-adapters e2e tests CW-2817: E2E tests Jan 18, 2022
Copy link
Collaborator

@walaszczykm walaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astonishing addition to the project CI setup 🤩
Good job with maintaining possibly low execution time as e2e tests are known for being slow 💪

Let's merge it! 🚀

@walaszczykm walaszczykm added the enhancement New feature or request label Jan 18, 2022
@klarzynskik klarzynskik merged commit 4a404b4 into master Jan 18, 2022
@klarzynskik klarzynskik deleted the feature/e2e-tests branch January 18, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants