Reinitialisation scheduling #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walaszczykm
added
bug
walaszczykm
force-pushed
the
feature/reinitialization-scheduling
branch
2 times, most recently
from
a84fff5
to
1a67a0c
Compare
walaszczykm
force-pushed
the
feature/reinitialization-scheduling
branch
from
1a67a0c
to
d5b070d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages
Issue
#51
Description
After investigating the original issue, it looks like the Widget cannot be properly destroyed during its initialization process as it might lead to unexpected errors. If the Widget starts loading, we need to wait until it is loaded before making a decision if it should be destroyed or not.
This PR implements reinitialization scheduling which relies on
LC_API.on_after_loadfor synchronous abut widget being initialized. Prevent from callingLiveChatWidget.destroy()while the widget is loading and track the last desired state instead of conditionally destroying it after it is fully loaded.