Fix proxy ws and other behavior #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yshayy
force-pushed
the
fix-proxy-ws-and-other-behavior
branch
from
f060d9f to
61d1a48
Compare
Yshayy
force-pushed
the
fix-proxy-ws-and-other-behavior
branch
from
f1c60e4 to
63ea419
Compare
royra
reviewed
Mar 16, 2023
royra
reviewed
Mar 16, 2023
royra
reviewed
Mar 16, 2023
royra
reviewed
Mar 16, 2023
royra
reviewed
Mar 16, 2023
royra
reviewed
Mar 16, 2023
royra
reviewed
Mar 16, 2023
| export const isProxyRequest = (baseUrl: {hostname:string, port:string}) => (req: IncomingMessage)=> { | ||
| const host = req.headers["host"] | ||
| if (!host) return false | ||
| const {hostname: reqHostname, port: reqPort} = new URL(`http://${host}`) |
There was a problem hiding this comment.
optimization nit creating a URL for each request might be more expensive than doing regex
There was a problem hiding this comment.
Started that way (actually started with splits and joins), but it shouldn't matter that much and and it's nicer to read
There was a problem hiding this comment.
nodejs/node#30334
actually slower then I thought, might replace it later
royra
reviewed
Mar 16, 2023
royra
reviewed
Mar 16, 2023
royra
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13, Grafana couldn't use websocket and also got weird errors in http requests. (project docker compose with Loki+Grafana)
The proxy didn't forward ws traffic as it require explicit forwarding of the ws socket. (using node-proxy
proxy.ws)Initially, I used the same approach and added websocket support to fastify and try to pass it to node-proxy, but it didn't work well.
Fastify offical proxy library is also incomplete.
End up using raw node.http handlers and rewiring it with fastify server factory.
All request with "preview" hosts (based on baseUrl) are skipping fastify handler pipeline.