fix: add retries to recover from realtime api text mode #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theomonnom
approved these changes
Nov 22, 2024
davidzhao
approved these changes
Nov 23, 2024
| @@ -902,6 +886,27 @@ async def set_chat_ctx(self, new_ctx: llm.ChatContext) -> None: | |||
| # wait for all the futures to complete | |||
| await asyncio.gather(*_futs) | |||
|
|
|||
| def _create_empty_user_audio_message(self, duration: float) -> llm.ChatMessage: | |||
There was a problem hiding this comment.
could you add a bit of comments regarding the approach? the PR comments are helpful, but someone reading the code wouldn't be able to find it.
There was a problem hiding this comment.
Added a comment for the _recover_from_text_response
🦋 Changeset detectedLatest commit: ae05954 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Nov 26, 2024
Merged
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the real-time API responds in text mode, so a retry method needs to be added to remove the text response, append an empty user audio message, and request a new response.
The example log messages: