-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OpenAI image detail parameter, and add support for Anthropic image data URLs #1213
Conversation
🦋 Changeset detectedLatest commit: 483eae1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@theomonnom updated to expand the scope, but let me know if you think we should keep iterating on the detail param... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to ignore but if you have time it would be great to add tests for images.
Otherwise lgtm (just fix CI)
@theomonnom yeah good idea, just added tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice awesome, definitely a great improvement to image handling
it can take some time for final transcriptions to arrive. we would use end-of-speech timing to compute end of utterance delay, instead of from the moment final transcripts arrive. also fixed the case where agents would be stuck when final transcripts do not end up coming in.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
23124d6
to
9b96433
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! nit on git lfs image
@theomonnom @nbsp this branch keeps failing CI on seemingly unrelated failures. I've gotten it to pass a couple times by rerunning. is this known in the repo or should I dig into to whether it really is coming from here? |
yes this is ffmpeg installation on macos failing, feel free to ignore |
Two vision-related improvements:
Also I improved error messages to be much clearer they're coming from the LiveKit stack and not from the openai or anthropic APIs