Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix imgui setup #1226

Merged
merged 4 commits into from
Dec 17, 2024
Merged

fix: fix imgui setup #1226

merged 4 commits into from
Dec 17, 2024

Conversation

mbukeRepo
Copy link
Contributor

@mbukeRepo mbukeRepo commented Dec 13, 2024 •
edited
Loading

Fixes #1227

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3cb0847

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-plugins-browser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@davidzhao davidzhao requested a review from theomonnom December 14, 2024 06:06
theomonnom
theomonnom reviewed Dec 14, 2024
View reviewed changes
livekit-plugins/livekit-plugins-browser/src/CMakeLists.txt Outdated
Comment on lines 22 to 25
execute_process(
COMMAND git fetch --unshallow
WORKING_DIRECTORY ${imgui_SOURCE_DIR}
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to unshallow?

Copy link
Contributor Author

@mbukeRepo mbukeRepo Dec 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking about this! I tried shallow cloning imgui and then unshallowing since the regular clone was timing out. This worked perfectly for me and resolved the timeout issue. Hope this helps! 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok interesting, I didn't have this issue but my guess is that we could even skip the unshallow part since we don't need the history

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the requested change 👍

theomonnom
theomonnom approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you sign the CLA before merging?

@mbukeRepo
Copy link
Contributor Author

Done!

theomonnom
theomonnom approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theomonnom theomonnom merged commit 52880aa into livekit:main Dec 17, 2024
1 check passed
This was referenced Dec 17, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to setup livekit-plugin-browser locally
3 participants
@mbukeRepo @CLAassistant @theomonnom