Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JPEG quality param to image encoder #1249

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Dec 17, 2024

The default through PIL appears to be 75 but it makes sense to give users explicit control.

While I was at it I added docstrings.

@bcherry bcherry requested a review from a team December 17, 2024 19:11
Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: a6769fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidzhao
Copy link
Member

some type issues.. need to use Optional[type] instead

Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bcherry bcherry merged commit 7e8c089 into main Dec 18, 2024
14 checks passed
@bcherry bcherry deleted the bcherry/encode-quality branch December 18, 2024 17:57
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants