Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v4 versions with multiple artifact download #1268

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Dec 21, 2024

Sorry about the previous breaking PR, this shouldn't have slipped past, but I only relied on the CI passing in the PR.

While it's not possible to upload multiple artifacts to the same name anymore with the v4 upload artifact action, it is possible to merge multiple artifact downloads into the same folder with v4 download artifact.

This PR merges all artifacts with the pattern python-package-dist-* into the dist folder. The idea is that no other changes are required, keeping the diff here minimal. Don't have a good way to test this though.

@lukasIO lukasIO requested a review from davidzhao December 21, 2024 09:27
Copy link

changeset-bot bot commented Dec 21, 2024

⚠️ No Changeset found

Latest commit: 15811a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasIO lukasIO requested a review from a team December 21, 2024 09:27
@lukasIO lukasIO requested a review from nbsp December 21, 2024 15:59
@lukasIO lukasIO merged commit 50d0a71 into main Dec 21, 2024
13 of 14 checks passed
@lukasIO lukasIO deleted the lukas/fix-v4-action branch December 21, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants