Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default audio bitrates #1295

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Increase default audio bitrates #1295

merged 2 commits into from
Oct 22, 2024

Conversation

davidzhao
Copy link
Member

Use full band audio 48kbps by default.

matches Rust behavior: livekit/rust-sdks#427

Use full band audio 48kbps by default.
@davidzhao davidzhao requested review from bcherry and lukasIO October 22, 2024 06:14
Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 0c019bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 22, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 83.88 KB (-0.01% 🔽)
dist/livekit-client.umd.js 89.94 KB (-0.01% 🔽)

@bcherry
Copy link
Contributor

bcherry commented Oct 22, 2024

@hiroshihorie @davidliu @cloudwebrtc does this suggest any changes we should make in iOS, Android, Flutter, etc?

@davidliu
Copy link
Contributor

@hiroshihorie @davidliu @cloudwebrtc does this suggest any changes we should make in iOS, Android, Flutter, etc?

Yeah, will need changes across the board for the other platforms as well.

@davidzhao davidzhao merged commit ad16627 into main Oct 22, 2024
3 checks passed
@davidzhao davidzhao deleted the fullband-audio branch October 22, 2024 06:36
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
@bcherry
Copy link
Contributor

bcherry commented Oct 22, 2024

@davidliu thanks - i filed three tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants