Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp broadcast IPC #565
base: main
Are you sure you want to change the base?
Revamp broadcast IPC #565
Changes from all commits
eed85f9
fd592db
ebaee5c
e223f5d
85f1b3d
68f3d45
002f835
d8c3f9a
fd4d65d
e2beb05
8deb4df
7b25d67
eb1fc39
fddf1ed
caa6923
c8ac5ba
b093eea
e02d487
1b88945
e8a1036
e32ae5d
2d7a8b8
179cf31
39224a3
a779853
7c4f8ea
3205da2
6183979
9559e65
ff62c25
356eb00
50a9c43
3f13b29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this have to be done within the task? it would be better if creating the receiver and assigning it to self could be done synchronously within createReceiver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a result of a design decision I made with
IPCChannel
, whichBroadcastReceiver
uses under the hood. Specifically, I designedIPCChannel
to use the RAII pattern, making its initialization asynchronous so that the consumer always receives an open channel after initialization. This approach also allowsIPCChannel
to conform toSendable
without additional synchronization, as the underlyingNWConnection
is both a constant (let) andSendable
. I am open to feedback about this design.This file was deleted.