iOS screen share audio #576
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `SocketConnectionFrameReader` to `SocketConnectionSampleReader`. - Utilize the new `HTTPMessageReader` and `BroadcastSampleDecoder` types. - Replaces the functionality of the existing `Message` class. - `didCapture` now emits a `BroadcastSample`. - General refactoring for enhanced readability.
- Uses the Network framework - Enables bi-directional communication and dynamic message headers
- Create `BroadcastUploader` and `BroadcastReceiver` utilizing `IPCChannel` - Separates concerns of socket communication, message format, and sample encoding/decoding - Integrate into existing code - Remove old components
Ensure proper handling of channel closure initiated either by the capture ending or the broadcast ending.
- Fix socket tests for iOS by using relative paths
Receiver must now request audio samples in order to receive them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for capturing application audio during screen share when using a broadcast extension.
Note: PR #565 should be merged first, as this PR is based on that branch.