check types after building protocol

livekit · Mar 19, 2024 · f8d4e71 · f8d4e71
1 parent 6b86458
commit f8d4e71
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/.github/workflows/build-protocol.yml b/.github/workflows/build-protocol.yml
@@ -38,12 +38,9 @@ jobs:
       - name: Install Protoc
         uses: arduino/setup-protoc@v2
         with:
-          version: "25.2"
+          version: "25.3"
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: install mypy-protobuf
-        run: pip3 install mypy-protobuf
-
       - name: generate python stubs
         run: ./generate_proto.sh
 

diff --git a/.github/workflows/check-types.yml b/.github/workflows/check-types.yml
@@ -1,10 +1,10 @@
 name: Check Types 
 
 on:
-  pull_request:
-    branches: [main, master]
-  push:
-    branches: [main, master]
+  workflow_run:
+    workflows: ["Build Protocol"]
+    types:
+      - completed
 
 jobs:
   type-check:
@@ -21,7 +21,7 @@ jobs:
         python-version: 3.9
 
     - name: Download ffi
-      run: "[[ ${{ inputs.package_name }} = 'livekit.rtc' ]] && pip install requests && python livekit-rtc/rust-sdks/download_ffi.py --output $(python -m site --user-site)/livekit/rtc/resources"
+      run: pip install requests && python livekit-rtc/rust-sdks/download_ffi.py --output $(python -m site --user-site)/livekit/rtc/resources
 
     - name: Install mypy 
       run: pip install --upgrade mypy