Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close function to Audio|Video Source #336

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

typester
Copy link
Member

No description provided.

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@davidzhao davidzhao requested a review from theomonnom December 28, 2024 06:27
@typester
Copy link
Member Author

After reading Lukas's comment, I was also unsure during implementation whether the Python side should be made async, so I’m leaving this as an open question.

Should we await self._join_handle or self._join_fut ? If the answer is yes, I think it would be better to implement this as an async aclose and include the logic to wait for them. What do you think? @davidzhao @theomonnom

@theomonnom
Copy link
Member

theomonnom commented Dec 28, 2024

Yes please, let's create a aclose function instead, we don't need to await the join handle but it is great to keep it async to be future proof on the future changes we could do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants