Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support non-utf8 std::string which can come e.g. from Windows message errors #193

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix: support non-utf8 std::string which can come e.g. from Windows message errors #193

merged 1 commit into from
Sep 22, 2023

Conversation

leanmendoza
Copy link
Contributor

Fix #192

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

theomonnom
theomonnom approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@theomonnom theomonnom merged commit 3e4669e into livekit:main Sep 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic in cxx when trying to build a string from a Windows call
3 participants
@leanmendoza @CLAassistant @theomonnom