Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New FFI for data packets. Support receiving DTMF. #319

Merged
merged 3 commits into from
Apr 9, 2024
Merged

New FFI for data packets. Support receiving DTMF. #319

merged 3 commits into from
Apr 9, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Apr 9, 2024

This is a breaking change, because I had to disable the DataReceived message. Otherwise caller will get two messages with the same data (old and new protocol). I hope removing all fields is enough to trigger an error on the target language SDK side during build, so that the author can update it to using DataPacketReceived message.

@dennwc dennwc requested a review from theomonnom April 9, 2024 13:57
@dennwc dennwc self-assigned this Apr 9, 2024
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dennwc dennwc merged commit 4b218a8 into main Apr 9, 2024
2 of 5 checks passed
@dennwc dennwc deleted the dtmf_ffi branch April 9, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants