Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for swapping out the HTTP Client #487

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add support for swapping out the HTTP Client #487

wants to merge 6 commits into from
+299 −92

Conversation

mikayla-maki
Copy link
Contributor

@mikayla-maki mikayla-maki commented Nov 15, 2024 •
edited
Loading

This PR updates the http_client to follow the dispatcher pattern.

@mikayla-maki mikayla-maki force-pushed the http-client-dispatcher branch from 46c1ca1 to 1f8eed2 Compare December 2, 2024 18:31
@mikayla-maki
Copy link
Contributor Author

Note that the dispatcher feature we use here was broken by the inclusion of "tokio" as a default runtime feature in: #495 combined with cargo always including default features from: #483

However, after fixing those bugs the livekit-runtime crate's default features are still being included. Haven't quite figured out why yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikayla-maki @theomonnom @mgsloan