Add support for a default config file #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to set config without making mist changes and also without cycling pods which is required for environment variable changes. This way we can add the config file via our existing mechanism to running pods and uploader will pick it up automatically
|
Nice! |
pwilczynskiclearcode
approved these changes
Jun 28, 2024
|
As a next step we could have a dynamically reloaded configs - every X seconds or on USR signal... Would be useful esp. for catalyst... but it might be difficult to implement it would require proper locking as updating config in the middle of a request might be evil. I mean for uploader it doesn't make sense probably but for catalyst might be useful |
Co-authored-by: Victor Elias <victorgelias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to set config without making mist changes and also without cycling pods which is required for environment variable changes. This way we can add the config file to running pods via our existing mechanism and the uploader will pick it up automatically.