refactor: replace 'Broadcaster' with 'Gateway' #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
rename_broadcaster_to_gateway
branch
2 times, most recently
from
34bf15b to
eea80c0
Compare
rickstaa
commented
May 16, 2024
| @@ -54,7 +53,8 @@ also contain instructions for using flags to enable certain functionality in | |||
|
|
|||
| - transcoder: Set to true to be an transcoder. Default `false` | |||
|
|
|||
| - broadcaster: Set to true to be an broadcaster. Default `false` | |||
| - gateway: Set to true to be an gateway (formerly known as a Broadcaster). | |||
There was a problem hiding this comment.
@dob I added a formerly known as Broadcaser to prevent confusion.
rickstaa
force-pushed
the
rename_broadcaster_to_gateway
branch
2 times, most recently
from
4a7abb1 to
61cd3ba
Compare
|
@dob, @thomshutt the only parts I found in the docs where confusion might arise are the parts that already use the Gateway term in another context:
|
This commit replaces all instances of 'Broadcaster' with 'Gateway' in accordance with a decision made by the core team. For more details, refer to the discussion at https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004.
rickstaa
force-pushed
the
rename_broadcaster_to_gateway
branch
from
61cd3ba to
650929b
Compare
thomshutt
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces all instances of 'Broadcaster' with 'Gateway' in
accordance with a decision made by the core team. For more details, refer to
the discussion at https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004.
@dob there are two places where I did not yet rename the broadcaster term:
Important
This pull request is dependent on the following upstream pull requests: