gomod, eth: fix nonce gap issues #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyriediculous
force-pushed
the
nv/nonce-gap
branch
from
9f3aaa1
to
fc6c9fb
Compare
|
Updated the PR to include a wrapper This PR is unlikely however to address nonce gap issues occuring in releases that already included the custom nonce manager. |
yondonfu
requested changes
Oct 24, 2019
3 tasks
yondonfu
requested changes
Oct 25, 2019
yondonfu
requested changes
Oct 25, 2019
|
fixed in 4eea557
…On Fri, Oct 25, 2019 at 9:31 PM Yondon Fu ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In cmd/livepeer_cli/livepeer_cli.go
<#1125 (comment)>:
> @@ -166,11 +166,11 @@ func (w *wizard) doCLIOpt(choice string, options []wizardOpt) {
log.Error("That's not something I can do")
}
-var RinkebyNetworkId = "4"
-var DevenvNetworkId = "54321"
+var RinkebychainID = "4"
Capitalize the "C" in chainID? Think that would be easier to read i.e.
RinkebyChainID and DevenvChainID
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1125?email_source=notifications&email_token=AFJZZWVZ5ZWZZV2BRCMOKLTQQNCSJA5CNFSM4JCN7JRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJJLGBY#pullrequestreview-307409671>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJZZWRJJHZHYQYBVNN5QJLQQNCSJANCNFSM4JCN7JRA>
.
|
yondonfu
reviewed
Oct 25, 2019
added 2 commits
October 25, 2019 21:51
kyriediculous
force-pushed
the
nv/nonce-gap
branch
from
4eea557
to
4f2e591
Compare
|
rebased ! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR upgrades the version of go-ethereum to include ethereum/go-ethereum#15794 in order to try to mitigate nonce issues that are occuring in the 0.3.3 go-livepeer release
Specific updates (required)
go-ethereum@1.9.3instead of our ownv.1.8.xfork to include internal/ethapi: ask transaction pool for pending nonce ethereum/go-ethereum#15794NonceManagerimplementation & usageeth/watchers/eventdecoderto match the API updates for the newgo-ethereumversiongo mod tidyHow did you test each of these updates (required)
Ran unit tests
Does this pull request close any open issues?
Fixes #1104
Checklist:
./test.shpass