Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use HTTP2 transport #1377

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Explicitly use HTTP2 transport #1377

merged 1 commit into from
Feb 12, 2020

Conversation

darkdarkdragon
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Explicitly use HTTP2 transport in communication between
orchestrator and transcoder.
Mitigates issue in the golang's implementation of HTTP2
golang/go#32441

How did you test each of these updates (required)
unit tests passes

Does this pull request close any open issues?

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

orchestrator and transcoder.
Mitigates issue in the golang's implementation of HTTP2
golang/go#32441
Copy link
Collaborator

@j0sh j0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 if manual testing also seems alright - don't think the network boundary is really unit-tested that thoroughly

@darkdarkdragon
Copy link
Contributor Author

Yes, tested manually, B->O->T flow works

@darkdarkdragon darkdarkdragon merged commit 75aa225 into master Feb 12, 2020
@darkdarkdragon darkdarkdragon deleted the it/explicithttp2 branch February 12, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants