server, net: Handle back compat for MP4. #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0sh
changed the title
j0sh
commented
Apr 6, 2020
j0sh
commented
Apr 6, 2020
core/orchestrator.go
Outdated
| @@ -663,7 +663,7 @@ func (rt *RemoteTranscoder) Transcode(job string, fname string, profiles []ffmpe | |||
| return nil, RemoteTranscoderFatalError{err} | |||
| } | |||
|
|
|||
| fullProfiles, err := common.FFmpegProfiletoNetProfile(profiles) | |||
| fullProfiles, _, err := common.FFmpegProfiletoNetProfile(profiles) | |||
There was a problem hiding this comment.
Assuming for now that standalone Ts will be upgraded in tandem with Os, so we aren't attempting to handle back compat here.
yondonfu
requested changes
Apr 7, 2020
3 tasks
yondonfu
reviewed
Apr 8, 2020
after a squash
This allows us to fail out quickly on orchestrators that do not recognize the FullProfile field.
Only use this field for non-mpegts profiles in order to maintain compatibility with older orchestrators. If an older orchestrator receives a request for non-mpegts transcoding, it will fail out.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is another approach to compatibility rather than a hard break via versioning as described in #1433 .
Makes MP4 requests fail out on orchestrators that don't support MP4 (or more generally, the
FullProfilefield for non-preset renditions introduced in Ar/handle custom bitrate ladder #1242 )Maintains compatibility with orchestrators that can only process mpegts
Specific updates (required)
FullProfiles2field to net.SegDataFullProfilesfield if the output format is only mpegts . This maintains compatibility with older orchestrators that only know mpegts.How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
./test.shpass