Add non-integer framerate support #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0sh
requested changes
Jun 3, 2020
There was a problem hiding this comment.
Looks great, just a few comments around test cases and field naming.
The webhook documentation also needs to be updated to reflect the new field: https://github.com/livepeer/go-livepeer/blob/master/doc/rtmpwebhookauth.md It probably doesn't hurt to mention in the doc that if the field is optional, and if omitted, a value of 1 is used by default.
* Add FPS denominator in Protobuf VideoProfile structs * Add unit tests to confirm correct conversion b/w LPMS & Protobuf VideoProfile * Ensure fee calculations & cost calculations work with non-int FPS * Add unit tests for calculation changes
j0sh
reviewed
Jun 4, 2020
Also update RTMP auth webhook docs to add info on the field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR adds support for non-integer framerates (#1474) by passing an optional FPS denominator field everywhere (like protobufs, webhooks etc.).
Specific updates (required)
FullProfiles3field to maintain back compat with late upgraders who wouldn't support the new Denominator fieldffmpeg.VideoProfiletonet.VideoProfile, also update webhook docs.How did you test each of these updates (required)
Does this pull request close any open issues?
Fixes #1474
Checklist:
./test.shpass