Record mode #1582
Merged
Record mode #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdarkdragon
force-pushed
the
it/record-mode
branch
from
6b057bc to
27ea0d6
Compare
iameli
previously requested changes
Jul 31, 2020
There was a problem hiding this comment.
So we're going to run into some trouble with nodeId.
- It's not set unless
-monitor=trueis set, which results in an empty string being used in the S3 upload URLs and playback breaking. - In on-chain mode it uses the broadcaster address... except that'll be the same across all of our production broadcasters in a region, so their JSON uploads will all collide.
I dunno what we wanna do about that exactly.
|
I tried to make a copy of this branch and accidentally deleted and recreated it, sorry if that causes problems anywhere 😂 |
darkdarkdragon
force-pushed
the
it/record-mode
branch
from
8d8aa7c to
078ee80
Compare
3 tasks
darkdarkdragon
force-pushed
the
it/record-mode
branch
4 times, most recently
from
dacab8a to
a8797e7
Compare
darkdarkdragon
force-pushed
the
it/record-mode
branch
11 times, most recently
from
d4f93f3 to
3da898f
Compare
darkdarkdragon
requested review from
iameli,
yondonfu,
kyriediculous and
jailuthra
darkdarkdragon
force-pushed
the
it/record-mode
branch
from
3da898f to
13a1b7b
Compare
darkdarkdragon
force-pushed
the
it/record-mode
branch
2 times, most recently
from
f24de4a to
4ca95f6
Compare
darkdarkdragon
force-pushed
the
it/record-mode
branch
from
4ca95f6 to
8406733
Compare
darkdarkdragon
force-pushed
the
it/record-mode
branch
from
c40faf1 to
7362431
Compare
yondonfu
reviewed
Nov 24, 2020
yondonfu
approved these changes
Nov 24, 2020
darkdarkdragon
force-pushed
the
it/record-mode
branch
from
79f515f to
8e34ca3
Compare
Add stub auth token to test
darkdarkdragon
force-pushed
the
it/record-mode
branch
from
8e34ca3 to
4096a43
Compare
- add `recordObjectStoreUrl` field to the webhook auth response - used as absolute URL to the segments saved to the recording object storage
darkdarkdragon
force-pushed
the
it/record-mode
branch
from
4096a43 to
2f54db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Allows to record streams
Specific updates (required)
-objectStorecommand line argument 4cfedeaPR allows to specify global OS for saving streams (using
-recordStorecommand line option) or to specify OS per-stream using webhook.Two fields added to webhook response structure:
objectStoreandrecordObjectStore.objectStorespecifies URL of OS to use for stream in transcoding pipeline, andrecordObjectStorespecifies URL of OS to store stream to.Recorded streams can be played back using http://broadcaster:8935/recordings/manifestID/index.m3u8 URL.
How did you test each of these updates (required)
Units tests
Does this pull request close any open issues?
Fixes #1609
Fixes #1572
Checklist:
./test.shpass