Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: make broadcaster and orchestrator config endpoint form values optional #1597

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

kyriediculous
Copy link
Contributor

@kyriediculous kyriediculous commented Aug 2, 2020

What does this pull request do? Explain your changes. (required)

This pull requests allows the form values passed into the setOrchestratorConfig and setBroadcasterConfig endpoints to be optional.

if a field is not provided then its related configuration will not be altered on the node.

This PR is a requirement for https://github.com/Livepool-io/livepeer-usd-pricer

How did you test each of these updates (required)

  • manual testing

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

server/webserver.go Outdated Show resolved Hide resolved
server/webserver.go Outdated Show resolved Hide resolved
server/webserver.go Outdated Show resolved Hide resolved
Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyriediculous kyriediculous merged commit e01f0ea into master Aug 8, 2020
@kyriediculous kyriediculous deleted the nv/optional-cli-cfg branch August 8, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants