Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: Remove gas price logging #1634

Merged
merged 1 commit into from
Oct 21, 2020
Merged

eth: Remove gas price logging #1634

merged 1 commit into from
Oct 21, 2020

Conversation

yondonfu
Copy link
Member

What does this pull request do? Explain your changes. (required)

This PR removes logging whenever the GasPriceMonitor fetches & caches the gas price returned by a eth_gasPrice RPC call.

I don't feel particularly strongly about this change, but it does seem like this log statement provides little to no utility and just results in a sizable (a new log every 5 seconds with the default -blockPollingInterval value) number of logs that need to be sifted through.

An alternative is to increase the verbosity of the log statement from DEBUG to VERBOSE as suggested here. Since there isn't really any actionable information in the current gas price log statements, I'm leaning towards just removing it altogether in this PR.

Specific updates (required)

See commit history.

How did you test each of these updates (required)

None.

Does this pull request close any open issues?

Closes #1483

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

Copy link
Contributor

@jailuthra jailuthra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Don't know enough to comment on removing the log altogether v/s switching it to VERBOSE, maybe Nico will have some thoughts there.

@kyriediculous
Copy link
Contributor

I don't have a strong opinion here either, it's only a bit verbose that during node idle times this is the only log being emitted every polling interval.

Removing it seems ok to me, I don't really use that log statement anyway.

@yondonfu yondonfu merged commit 1cbb230 into master Oct 21, 2020
@yondonfu yondonfu deleted the yf/gas-price-logging branch October 21, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verbose setting for transcoding related activities only
3 participants