Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR removes logging whenever the GasPriceMonitor fetches & caches the gas price returned by a
eth_gasPrice
RPC call.I don't feel particularly strongly about this change, but it does seem like this log statement provides little to no utility and just results in a sizable (a new log every 5 seconds with the default -blockPollingInterval value) number of logs that need to be sifted through.
An alternative is to increase the verbosity of the log statement from DEBUG to VERBOSE as suggested here. Since there isn't really any actionable information in the current gas price log statements, I'm leaning towards just removing it altogether in this PR.
Specific updates (required)
See commit history.
How did you test each of these updates (required)
None.
Does this pull request close any open issues?
Closes #1483
Checklist:
./test.sh
pass