Fix memory leak #1644
Merged
Fix memory leak #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iameli
reviewed
Oct 22, 2020
| @@ -25,6 +25,7 @@ import ( | |||
| "github.com/stretchr/testify/assert" | |||
| "github.com/stretchr/testify/mock" | |||
| "github.com/stretchr/testify/require" | |||
| "go.uber.org/goleak" | |||
There was a problem hiding this comment.
slick name. this makes me want to do go.livepeer.org/whatever for purely cosmetic reasons
There was a problem hiding this comment.
I like the idea 😃
There was a problem hiding this comment.
actually we totally should, looks like it's as easy as https://github.com/GoogleCloudPlatform/govanityurls
There was a problem hiding this comment.
Now we need package to publish 😃
|
Interesting that we've never noticed this. When would it show up? |
Found it in the logs for #1640 |
yondonfu
reviewed
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes memory leak caused by unbuffered channels
Specific updates (required)
Added buffers to channels
How did you test each of these updates (required)
unit tests
Does this pull request close any open issues?
Checklist:
./test.shpass