Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some transcoding metrics for O + T split #1655

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Add some transcoding metrics for O + T split #1655

merged 3 commits into from
Nov 9, 2020

Conversation

yondonfu
Copy link
Member

@yondonfu yondonfu commented Nov 6, 2020

What does this pull request do? Explain your changes. (required)

Add a few transcoding metrics for a O + T split:

  • Log the round trip between O & T from O's POV
  • Log and record the download duration from T on O (use taskID for seqNo)
  • Log and record the upload duration to O on a standalone T (use taskID for seqNo)
  • Log and record the transcode duration for a standalone Nvidia T

Specific updates (required)

See commit history.

How did you test each of these updates (required)

Tested manually.

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

darkdarkdragon
darkdarkdragon approved these changes Nov 8, 2020
View reviewed changes
Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jailuthra
jailuthra approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@jailuthra jailuthra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@yondonfu yondonfu merged commit 72eea36 into master Nov 9, 2020
@yondonfu yondonfu deleted the yf/transcoder-metrics branch November 9, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdarkdragon darkdarkdragon darkdarkdragon approved these changes

@jailuthra jailuthra jailuthra approved these changes

@kyriediculous kyriediculous Awaiting requested review from kyriediculous

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yondonfu @jailuthra @darkdarkdragon