Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User session #1674

Merged
merged 4 commits into from
Dec 2, 2020
Merged

User session #1674

merged 4 commits into from
Dec 2, 2020

Conversation

darkdarkdragon
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Join couple of transcoding sessions to
one 'user' session in recordings

Specific updates (required)

  • add 'previousSessions' field to the AuthWebhook response
  • in /recordings handler use 'previousSessions' field's content to find all the transcoding sessions belonging to this one
    'user' session and join them to one manifest

How did you test each of these updates (required)
Manually

Does this pull request close any open issues?

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

one 'user' session in recordings
server/mediaserver.go Outdated Show resolved Hide resolved
server/mediaserver.go Outdated Show resolved Hide resolved
server/mediaserver.go Outdated Show resolved Hide resolved
server/mediaserver.go Outdated Show resolved Hide resolved
@yondonfu
Copy link
Member

yondonfu commented Dec 2, 2020

Would be nice to have a unit test for checking the session merging functionality.

@darkdarkdragon
Copy link
Contributor Author

@yondonfu added unit test

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the unit test. Would also be nice to have that new behavior in the HandleRecordings handler to be unit tested, but the handler is pretty hefty and creating the necessary stubs may be tricky so if you feel like manual testing did the trick then I think that's ok.

LGTM

@darkdarkdragon darkdarkdragon merged commit 7138591 into master Dec 2, 2020
@darkdarkdragon darkdarkdragon deleted the it/record-2 branch December 2, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants