eth: rewardservice to use round subscription #1696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Remove polling on a set interval (which executes a ton of RPC requests) to only trying reward when a new round event is received from the
TimeWatcher
.Specific updates (required)
rewardService.Start
and block instead. This follows the convention of most of our other servicesTimeWatcher
so that we can unit test this serviceeth.MockClient
to facilitate unit testsserviceErr
to catch errors from startup goroutines for several services (currently rewardService and redeemer)How did you test each of these updates (required)
Manually tested using the devtool and added log events
Unit tests
Does this pull request close any open issues?
Fixes #1584
Checklist:
./test.sh
pass