Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server,core: Improve in-flight segment handling #1749

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Conversation

jailuthra
Copy link
Contributor

@jailuthra jailuthra commented Jan 28, 2021

What does this pull request do? Explain your changes. (required)

Fix the bugs in, and clean up the logic of the recently introduced flexible segment-in-flight feature between the B & O.

Specific updates (required)

  • Remove segments from the in-flight queue only after downloading
  • Add goroutines in the test to check for race conditions around selectSession() and completeSession()
  • Simplify completeSession logic, and always make sure bsm.lastSess is set to the updated session (with the updated SegsInFlight queue)
  • Increase channel buffer count of LB transcoder to match that of the O set previously

How did you test each of these updates (required)

  • Manual testing with simultaneous curl calls
  • Unit tests with stubbed sessions

Does this pull request close any open issues?

Fixes #1742 and Fixes #1743

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

@jailuthra jailuthra marked this pull request as ready for review January 28, 2021 17:15
server/broadcast.go Outdated Show resolved Hide resolved
server/broadcast.go Outdated Show resolved Hide resolved
server/broadcast.go Outdated Show resolved Hide resolved
server/broadcast.go Outdated Show resolved Hide resolved
server/broadcast.go Outdated Show resolved Hide resolved
server/broadcast.go Outdated Show resolved Hide resolved
server/broadcast.go Outdated Show resolved Hide resolved
@jailuthra jailuthra requested review from yondonfu and iameli January 29, 2021 04:55
@jailuthra jailuthra changed the title Improve in-flight segment handling server,core: Improve in-flight segment handling Jan 29, 2021
Copy link
Contributor

@iameli iameli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants