-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enumerate Nvidia GPU IDs #1840
Enumerate Nvidia GPU IDs #1840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're using a package that gives us access to all device info now, an additional UX improvement could be to log the Nvidia device names that the node is configured with on startup so it is clear to the user what devices are being used. Feel free to consider this for a separate PR though.
414eeae
to
4af035b
Compare
Fixed pending comments, and squashed+rebased on top of latest
That would be a very cool feature. Will open a separate tracking issue for it. |
Requested changes look good to me, will let Yondon follow up on his change requests seperately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Windows build is failing due to what looks like a flaky gpg issue. Please trigger another build just to check if the Windows build passes and then this should be good to merge.
bbdb649
to
6ef16f6
Compare
Squashed the fixup to trigger windows re-build. Everything works now. Merging. |
What does this pull request do? Explain your changes. (required)
Automatically utilize all available Nvidia GPUs for transcoding, if the user sets the command line parameter as
-nvidia=all
or-nvidia all
.Specific updates (required)
See commit history
How did you test each of these updates (required)
Manually tested, and verified correct behaviour on:
Does this pull request close any open issues?
Fixes #1205
Checklist:
make
runs successfully./test.sh
pass