cmd: Adds check for invalid inferred IP #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyriediculous
suggested changes
Apr 29, 2021
reubenr0d
force-pushed
the
nil-pointer-ip-lookup
branch
from
3e7ad75 to
33401de
Compare
kyriediculous
suggested changes
Apr 30, 2021
reubenr0d
force-pushed
the
nil-pointer-ip-lookup
branch
from
33401de to
bf34994
Compare
|
There appears to be a merge conflict, you should be able to pull the latest upstream master and rebase on top of it. Once that's done should be GTG. |
reubenr0d
force-pushed
the
nil-pointer-ip-lookup
branch
from
9561302 to
0b57e34
Compare
|
I forgot to mention, let's keep the PR open until a bounty is attached |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
https://api.ipify.org?format=textresponds with success but there is an issue in the responseHow did you test each of these updates (required)
body = []byte("%")to reproduce the errorDoes this pull request close any open issues?
Fixes #1829
Checklist:
makeruns successfully./test.shpass