Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm: refresh ticket params before expiry from sender side #1877

Merged
merged 1 commit into from
May 19, 2021

Conversation

kyriediculous
Copy link
Contributor

@kyriediculous kyriediculous commented May 6, 2021

What does this pull request do? Explain your changes. (required)
Refresh TicketParams for the active orchestrator session on the broadcaster at 10% before they expire.

Specific updates (required)

  • Updated the expiry check in sender.ValidateTicketParams

How did you test each of these updates (required)

  • Added unit tests

Does this pull request close any open issues?
Fixes #1852

Checklist:

pm/recipient.go Outdated Show resolved Hide resolved
pm/sender.go Outdated Show resolved Hide resolved
@kyriediculous kyriediculous requested a review from yondonfu May 19, 2021 02:02
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after squashing & fixing merge conflict.

@kyriediculous kyriediculous merged commit 8e5df3b into master May 19, 2021
@kyriediculous kyriediculous deleted the nv/refresh-tp branch May 19, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh session when within the last 10% of ticket params validity period
2 participants