monitor+server: Record million pixels processed metric #1899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Adds a million pixels processed metric. For now, this is only recorded on B by taking the total pixel count for a set of transcoded results, dividing it by 1m and then recording the result. This metric is helpful for monitoring pixel throughput on a B while also monitoring payment/ticket throughput since the latter should be based on the former.
The risk of overflow while using a float64 to record the metric should be minimal. Consider the following example:
So, with 1000000 streams running 24/7 for an entire year the million pixels value should still be below the max float64 value.
Specific updates (required)
mil_pixels_processed
metric in themonitor
packagemil_pixels_processed
metric on B after counting the pixels in the transcoded resultsHow did you test each of these updates (required)
Manually.
Does this pull request close any open issues?
N/A
Checklist:
make
runs successfully./test.sh
pass