Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http push: return 422 for non-retryable errors #1934

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

darkdarkdragon
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
In HTTP push handler returns 422 status code for non-retryable errors

Specific updates (required)

  • Return 422 statuc code

How did you test each of these updates (required)
unit test

Does this pull request close any open issues?
Fixes #1927

Checklist:

server/push_test.go Outdated Show resolved Hide resolved
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkdarkdragon darkdarkdragon merged commit f4368ae into master Jun 29, 2021
@darkdarkdragon darkdarkdragon deleted the it/invalid-request branch June 29, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return HTTP 422 if a segment contains I-frames but not keyframes
2 participants